Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The menu does not close when choosing a category #6

Open
Rayochoco opened this issue Dec 29, 2021 · 9 comments
Open

The menu does not close when choosing a category #6

Rayochoco opened this issue Dec 29, 2021 · 9 comments
Labels
bug Something isn't working

Comments

@Rayochoco
Copy link

Describe the error
When displaying the menu and select any category of first level, second level or third level, if it redirects to the page but the menu remains open and should close

play
Steps to reproduce the behavior:

1.-Go 'Hamburger button'
2.-Click on 'Button'
3.-Select any category
See error
Expected behavior
Redirect to the page and close the menu.
Captura de pantalla de 2021-12-28 18-53-12
Click on category
Captura de pantalla de 2021-12-28 18-54-29

@Rayochoco Rayochoco added the bug Something isn't working label Dec 29, 2021
@trewous
Copy link

trewous commented Jan 21, 2022

I have version 2.x and bug doesn't occur.

@ejisselgb
Copy link
Contributor

Hello @Rayochoco what version do you have in the manifest? This problem occurs in the version minor of 2.x

@Rayochoco
Copy link
Author

Rayochoco commented Feb 1, 2022

hello @ejisselgb , I have version 0.x in the manifest, but it won't let me install version 2.x

Captura de pantalla de 2022-02-01 16-14-39

@ejisselgb
Copy link
Contributor

Hi @Rayochoco, Can you show me all the errors in the console, please? Do you try to update the app from VTEX AppStore? Do you accept the contract?

@Rayochoco
Copy link
Author

Hi @ejisselgb
Captura de pantalla de 2022-02-03 09-48-38
in the manifest it does not allow me to put "vtex.mega-menu": "2.x", it sends me the following error
Captura de pantalla de 2022-02-03 10-01-20

@trewous
Copy link

trewous commented Feb 3, 2022

@Rayochoco you have to install the app, uninstall previous versions. Also make sure you add app in "peerDependecies" not in "dependecies"

@trewous
Copy link

trewous commented Feb 3, 2022

@Rayochoco apps that have billing options in manifest need to be inserted in "peerDependecies" and installed manualy.

@ejisselgb
Copy link
Contributor

ejisselgb commented Feb 4, 2022

@Rayochoco Someone was a similar error. He defined the mega-menu in the peerDependencies. Let me know if your error continues.
image (16)

@Rayochoco
Copy link
Author

@ejisselgb @trewous the error is already solved, thanks for the attention

cristian-milea pushed a commit to AuchanRomania/auchan.mega-menu that referenced this issue Mar 24, 2023
cristian-milea pushed a commit to AuchanRomania/auchan.mega-menu that referenced this issue Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants