Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sponsoredBadgeLabel added as a required prop #389

Open
bruno-monteiro1 opened this issue Dec 12, 2023 · 0 comments
Open

sponsoredBadgeLabel added as a required prop #389

bruno-monteiro1 opened this issue Dec 12, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@bruno-monteiro1
Copy link

Describe the bug
The prop sponsoredBadgeLabel was added to the ProductSummaryName component, but not as optional, even though the component to which it passes on receives it as optional. This change got release as a minor (2.87.0), but breaks TS build on projects that depend on this.

To Reproduce
No need to reproduce, just check the sponsoredBadgeLabel typing on the ProductSummaryName component and see that it is required. Than, check that it is optional in the only component it gets passed on.

Expected behavior
The expected behaviour is that the prop is set as optional, not only because it is optional in the component it gets passed on, but also because it did not exist in previous versions of the same major.

@bruno-monteiro1 bruno-monteiro1 added the bug Something isn't working label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant