Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.5.14] VTimePicker updates models very lazy #19545

Closed
KIDS-interactive opened this issue Apr 5, 2024 · 11 comments · Fixed by #20179
Closed

[Bug Report][3.5.14] VTimePicker updates models very lazy #19545

KIDS-interactive opened this issue Apr 5, 2024 · 11 comments · Fixed by #20179
Assignees
Labels
C: VTimePicker T: bug Functionality that does not work as intended/expected

Comments

@KIDS-interactive
Copy link

KIDS-interactive commented Apr 5, 2024

Environment

Vuetify Version: 3.5.14
Last working version: 2.7.2
Vue Version: 3.4.21
Browsers: Chrome 123.0.0.0
OS: Windows 10

Steps to reproduce

The timePicker doesnt trigger an model-update or an hour update very often.
In vuetify2 it was updated on every scroll and click, so the user could confirm or abort. Now there is only an v-model update on hour and minute confirmation.

Expected Behavior

update:hour and update:minute triggers on every visible change.
v-model updates on every visible change

Actual Behavior

v-model updates only after hour and minute selection
update:hour and update:minute triggers only on click

Reproduction Link

https://play.vuetifyjs.com/#...

In Vuetify2: https://v2.vuetifyjs.com/en/components/time-pickers/#dialog-and-menu
Click on "Dialog" - here you can confirm with "ok" - the model was updated more frequently (you can see it in the input-field)

@chrislol98
Copy link

cant trigger update:minute, theres got to be some bugs

@KIDS-interactive
Copy link
Author

KIDS-interactive commented Apr 9, 2024

i suggest to use an debounced call on update, so you don't have too few or too many updates on the model

@blalan05 blalan05 linked a pull request Apr 9, 2024 that will close this issue
@blalan05
Copy link
Member

blalan05 commented Apr 9, 2024

cant trigger update:minute, theres got to be some bugs

This PR fixes that.

@KIDS-interactive
Copy link
Author

KIDS-interactive commented Apr 10, 2024

@blalan05 Unfortunately, still no update is triggered when you scroll. Could you implement this with an debounce? And thanks for your effort!

https://play.vuetifyjs.com/#...

VPlay.-.Google.Chrome.2024-04-10.09-02-18.online-video-cutter.com.mp4

@m2xilon
Copy link

m2xilon commented Apr 15, 2024

@blalan05 currently selecting a different hour but same minute will not trigger @update:model-value either.
playground example

Screenshare.-.2024-04-15.3_11_13.PM.mp4

Additionally getting the following when updating to a different time to the one currently set
image

@Maqsyo
Copy link

Maqsyo commented May 14, 2024

@blalan05 is there any plan to fix this issue soon? 🙈

@benwick
Copy link

benwick commented Jun 19, 2024

@blalan05 Any progress on this issue?

@KIDS-interactive
Copy link
Author

@KaelWD is there any plan to release this component?
Would you accept an bounty to focus on this?

@KIDS-interactive
Copy link
Author

@johnleider Maybe you can help?

@blalan05
Copy link
Member

I think this PR may fix this, I've changed how and when it emits the value, #20179

@YournameITManoah
Copy link

Could the fix be merged soon? Shouldn't be too complicated...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VTimePicker T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants