-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Report][3.5.14] VTimePicker updates models very lazy #19545
Comments
cant trigger update:minute, theres got to be some bugs |
i suggest to use an debounced call on update, so you don't have too few or too many updates on the model |
This PR fixes that. |
@blalan05 Unfortunately, still no update is triggered when you scroll. Could you implement this with an debounce? And thanks for your effort! https://play.vuetifyjs.com/#... VPlay.-.Google.Chrome.2024-04-10.09-02-18.online-video-cutter.com.mp4 |
@blalan05 currently selecting a different hour but same minute will not trigger @update:model-value either. Screenshare.-.2024-04-15.3_11_13.PM.mp4Additionally getting the following when updating to a different time to the one currently set |
@blalan05 is there any plan to fix this issue soon? 🙈 |
@blalan05 Any progress on this issue? |
@KaelWD is there any plan to release this component? |
@johnleider Maybe you can help? |
I think this PR may fix this, I've changed how and when it emits the value, #20179 |
Could the fix be merged soon? Shouldn't be too complicated... |
Environment
Vuetify Version: 3.5.14
Last working version: 2.7.2
Vue Version: 3.4.21
Browsers: Chrome 123.0.0.0
OS: Windows 10
Steps to reproduce
The timePicker doesnt trigger an model-update or an hour update very often.
In vuetify2 it was updated on every scroll and click, so the user could confirm or abort. Now there is only an v-model update on hour and minute confirmation.
Expected Behavior
update:hour
andupdate:minute
triggers on every visible change.v-model
updates on every visible changeActual Behavior
v-model
updates only after hour and minute selectionupdate:hour
andupdate:minute
triggers only on clickReproduction Link
https://play.vuetifyjs.com/#...
In Vuetify2: https://v2.vuetifyjs.com/en/components/time-pickers/#dialog-and-menu
Click on "Dialog" - here you can confirm with "ok" - the model was updated more frequently (you can see it in the input-field)
The text was updated successfully, but these errors were encountered: