Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CopyHeaders is using http.Header.Add() that capitalizes the headers #30

Open
djannot opened this issue Feb 19, 2016 · 4 comments
Open

Comments

@djannot
Copy link

djannot commented Feb 19, 2016

It makes oxy incompatible with several clients, like the ones using the Amazon S3 API

See the link below for more information:
golang/go#5022

Could you please use the following approach ?

func CopyHeaders(dst, src http.Header) {
for k, vv := range src {
for _, v := range vv {
dat[k] = v
}
}

djannot added a commit to djannot/traefik that referenced this issue Feb 19, 2016
@klizhentas
Copy link
Contributor

sure, this makes sense

@travisghansen
Copy link

I'm not a go person. Does the approach above preserve the headers in their original state?

I'm trying to use traefik which apparently leverages this under the hood and it's really causing some issues even though headers are supposed to be case-insensitive.

@Herz3h
Copy link

Herz3h commented Sep 5, 2019

We are also using Traefik, and face the same issue regarding the case sensitivity of headers. Is there a fix for this in oxy ?

@cmullendore
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants