Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

011_googlemeet-segmentation-worker-js example has errors #47

Open
ArtemOstapov opened this issue May 5, 2022 · 3 comments
Open

011_googlemeet-segmentation-worker-js example has errors #47

ArtemOstapov opened this issue May 5, 2022 · 3 comments

Comments

@ArtemOstapov
Copy link

011_googlemeet-segmentation-worker-js example does not work from the box.
It has the next errors:

1. in old version of the lib, predict api was:
predict: (targetCanvas: HTMLCanvasElement, params?: GoogleMeetSegmentationOperationParams) => Promise<number[][] | null>;
and in new one now:
predict: (params: GoogleMeetSegmentationOperationParams | undefined, targetCanvas: HTMLCanvasElement) => Promise<Uint8ClampedArray | null>;

so parameters order was changed, but in the code predict call - was not updated.

2. Return value was
Promise<number[][] | null>
and now it ls:
Promise<Uint8ClampedArray | null>

but createForegroundImage needs number[][]
export declare const createForegroundImage: (srcCanvas: HTMLCanvasElement, prediction: number[][]) => ImageData;

plz do corresponding updates

@w-okada
Copy link
Owner

w-okada commented May 12, 2022

Sorry, late response.
I'll check. please wait.

@w-okada
Copy link
Owner

w-okada commented May 12, 2022

Thank you for your comment. I update Readme.md of 011_googlemeet-segmentation-worker-js.
Please see https://github.com/w-okada/image-analyze-workers/tree/master/011_googlemeet-segmentation-worker-js

@ArtemOstapov
Copy link
Author

Thank you for your comment. I update Readme.md of 011_googlemeet-segmentation-worker-js. Please see https://github.com/w-okada/image-analyze-workers/tree/master/011_googlemeet-segmentation-worker-js

tnx for the updates.

Could plz share a link to docs, where a new params are explained?
i'm talking about api: generateDefaultGoogleMeetSegmentationParams, because in old build there was quite different params.

tnx in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants