Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render tests: capture all channels images for the same frame #770

Open
w23 opened this issue Mar 4, 2025 · 0 comments
Open

Render tests: capture all channels images for the same frame #770

w23 opened this issue Mar 4, 2025 · 0 comments
Labels
autotest Things useful for automated testing/CI bug Something isn't working enhancement New feature or request management Repository management issues ray tracing visual bug Visual glitches, something looks incorrectly

Comments

@w23
Copy link
Owner

w23 commented Mar 4, 2025

Currently render tests advance for the next frame for each channel, so that different channel images are not taken for the same frame. This doesn't help with determinism, as frame deltas vary, subtly affecting various things.
Why it is done so: rendertests are added cheaply on top of debug single-channel display and taking screenshots.

Ideally, there'd be a special command that'd capture all channels at once and store them together.

It'd be also great to make engine more deterministic, at least synchronise with the first frame, and/or provide fake fixed framerate for the first few frames (for the denoiser to collect more statistics).
That being said we'd probably benefit from having rendertests for

  • first frame (raw, not temporally denoised)
  • Nth frame (temporally denoised)
@w23 w23 added autotest Things useful for automated testing/CI bug Something isn't working enhancement New feature or request management Repository management issues ray tracing visual bug Visual glitches, something looks incorrectly labels Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autotest Things useful for automated testing/CI bug Something isn't working enhancement New feature or request management Repository management issues ray tracing visual bug Visual glitches, something looks incorrectly
Projects
None yet
Development

No branches or pull requests

1 participant