Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo: Return promise vs resolve promise #226

Closed
joeyparrish opened this issue Jun 7, 2024 · 2 comments · Fixed by #227
Closed

Typo: Return promise vs resolve promise #226

joeyparrish opened this issue Jun 7, 2024 · 2 comments · Fixed by #227

Comments

@joeyparrish
Copy link
Member

I believe here:

4. Return |promise| with the <a>Picture-in-Picture window</a> associated with

Return promise ...

Should say:

Resolve promise ...

@marcoscaceres
Copy link
Member

Agree. Further, retuning the promise should be step 1, then go in parallel, then eventually queue a task to resolve it.

@beaufortfrancois
Copy link
Collaborator

Thanks @joeyparrish for catching this!
I've opened #227 to address this issue.

@marcoscaceres The first sentence says The {{requestPictureInPicture()}} method, when invoked, MUST return <a>a new promise</a> |promise| and run the following steps <a>in parallel</a>: which I believe should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants