From d5f7c33a8e3b9170b0e1b3cf6a644464e9022d52 Mon Sep 17 00:00:00 2001 From: Tim Cappalli Date: Thu, 1 Aug 2024 03:28:57 +0900 Subject: [PATCH 1/4] Add PR template --- .github/pull_request_template.md | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 000000000..8e7825b54 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,18 @@ +Closes #??? + +The following tasks have been completed: + +- [ ] Modified Web platform tests (link) + +Implementation commitment: + +- [ ] WebKit (link to issue) +- [ ] Chromium (link to issue) +- [ ] Gecko (link to issue) + +Documentation and checks + +- [ ] Affects privacy +- [ ] Affects security +- [ ] Pinged MDN +- [ ] Updated Explainer From 902af61dc7aa15229b6aad92f0dd998e43de8f91 Mon Sep 17 00:00:00 2001 From: Tim Cappalli Date: Thu, 1 Aug 2024 04:00:09 +0900 Subject: [PATCH 2/4] adds links Co-authored-by: Nina Satragno --- .github/pull_request_template.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 8e7825b54..cd11aec73 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,17 +2,17 @@ Closes #??? The following tasks have been completed: -- [ ] Modified Web platform tests (link) +- [ ] Modified Web platform tests ([link](https://github.com/web-platform-tests/wpt/)) Implementation commitment: -- [ ] WebKit (link to issue) -- [ ] Chromium (link to issue) -- [ ] Gecko (link to issue) +- [ ] WebKit ([link to issue](https://bugs.webkit.org/)) +- [ ] Chromium ([link to issue](https://issues.chromium.org/issues/new?component=1456855&template=0)) +- [ ] Gecko ([link to issue](https://bugzilla.mozilla.org/home)) Documentation and checks - [ ] Affects privacy - [ ] Affects security - [ ] Pinged MDN -- [ ] Updated Explainer +- [ ] Updated explainer ([link](https://github.com/w3c/webauthn/wiki) From 4c22cbe8ad4fc5f441c024c3eb0fdb3fcb6d5ee7 Mon Sep 17 00:00:00 2001 From: Tim Cappalli Date: Wed, 7 Aug 2024 23:54:21 +0900 Subject: [PATCH 3/4] non-normative comment --- .github/pull_request_template.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index cd11aec73..e35a495b9 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,5 +1,7 @@ Closes #??? + + The following tasks have been completed: - [ ] Modified Web platform tests ([link](https://github.com/web-platform-tests/wpt/)) From d261d9ebf8ca57b299ae97de33bfa6c2d185d4f9 Mon Sep 17 00:00:00 2001 From: Tim Cappalli Date: Thu, 15 Aug 2024 03:28:05 +0900 Subject: [PATCH 4/4] Remove MDN Removes contact MDN item --- .github/pull_request_template.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index e35a495b9..95e2d8840 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -16,5 +16,4 @@ Documentation and checks - [ ] Affects privacy - [ ] Affects security -- [ ] Pinged MDN - [ ] Updated explainer ([link](https://github.com/w3c/webauthn/wiki)