Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up bikeshed issues before L3 publish #2226

Closed
timcappalli opened this issue Jan 12, 2025 · 1 comment · Fixed by #2227
Closed

Clean up bikeshed issues before L3 publish #2226

timcappalli opened this issue Jan 12, 2025 · 1 comment · Fixed by #2227
Assignees
@timcappalli
Labels
type:editorial

Comments

@timcappalli
Copy link
Member

timcappalli commented Jan 12, 2025 •
edited
Loading

This shouldn't block PR of L3, but we should try to clean these up.

bikeshed --version
4.1.6

<< edit - see comment >>
@timcappalli timcappalli self-assigned this Jan 12, 2025
@timcappalli
Copy link
Member Author

All but the SVG issues went away after upgrading to latest Bikeshed (4.2.8) 🙃

  • LINE 1469: Couldn't determine width and height of this image: 'images/webauthn-registration-flow-01.svg'
    cannot identify image file '/Users/tim.cappalli/code/src/gh/w3c/webauthn/images/webauthn-registration-flow-01.svg'
  • LINE 1479: Couldn't determine width and height of this image: 'images/webauthn-authentication-flow-01.svg'
    cannot identify image file '/Users/tim.cappalli/code/src/gh/w3c/webauthn/images/webauthn-authentication-flow-01.svg'
  • LINE 4786: Couldn't determine width and height of this image: 'images/fido-signature-formats-figure1.svg'
    cannot identify image file '/Users/tim.cappalli/code/src/gh/w3c/webauthn/images/fido-signature-formats-figure1.svg'
  • LINE 5374: Couldn't determine width and height of this image: 'images/fido-signature-formats-figure2.svg'
    cannot identify image file '/Users/tim.cappalli/code/src/gh/w3c/webauthn/images/fido-signature-formats-figure2.svg'
  • LINE 5486: Couldn't determine width and height of this image: 'images/string-truncation.svg'
    cannot identify image file '/Users/tim.cappalli/code/src/gh/w3c/webauthn/images/string-truncation.svg'
  • LINE 5567: Couldn't determine width and height of this image: 'images/fido-attestation-structures.svg'
    cannot identify image file '/Users/tim.cappalli/code/src/gh/w3c/webauthn/images/fido-attestation-structures.svg'
  • LINE ~2376: Multiple possible 'document' dfn refs.
    Arbitrarily chose https://dom.spec.whatwg.org/#clone-a-node-document
    To auto-select one of the following refs, insert one of these lines into a 
     block:
    
spec:dom; type:dfn; for:clone a node; text:document
    
spec:dom; type:dfn; for:/; text:document
    
[=Document=]
  • LINE ~3980: Multiple possible 'document' dfn refs.
    Arbitrarily chose https://dom.spec.whatwg.org/#clone-a-node-document
    To auto-select one of the following refs, insert one of these lines into a 
     block:
    
spec:dom; type:dfn; for:clone a node; text:document
    
spec:dom; type:dfn; for:/; text:document
    
[=Document=]

@timcappalli timcappalli mentioned this issue Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timcappalli timcappalli

Labels
type:editorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bikeshed warnings w3c/webauthn
1 participant
@timcappalli