Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to set the cache mode when intercepting requests #724

Open
jgraham opened this issue May 31, 2024 · 5 comments
Open

Add the ability to set the cache mode when intercepting requests #724

jgraham opened this issue May 31, 2024 · 5 comments
Labels
enhancement New feature or request module-network Network module needs-discussion Issues to be discussed by the working group

Comments

@jgraham
Copy link
Member

jgraham commented May 31, 2024

#721 adds a command to override the cache mode for all requests in a specific browsing context. But it could also be useful to override it for specific requests that are intercepted in the beforeRequestSent phase.

@whimboo whimboo added enhancement New feature or request needs-discussion Issues to be discussed by the working group module-network Network module labels May 31, 2024
@whimboo
Copy link
Contributor

whimboo commented Jun 5, 2024

@jgraham I think that we can close this issue as dupe of #582?

@jgraham
Copy link
Member Author

jgraham commented Jun 5, 2024

This is the issue you suggested I file for followup work related specifically to overrides in beforeRequestSent :)

@whimboo
Copy link
Contributor

whimboo commented Jun 5, 2024

Sorry, I misread. Should we actually discuss that next week?

@whimboo
Copy link
Contributor

whimboo commented Jul 4, 2024

@OrKoN, does Puppeteer currently use a per-interception-based network cache behavior? If not, is this something you might consider implementing?

@OrKoN
Copy link
Contributor

OrKoN commented Jul 5, 2024

Puppeteer does not use this currently and we do not have a feature request for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module-network Network module needs-discussion Issues to be discussed by the working group
Projects
None yet
Development

No branches or pull requests

3 participants