From 438db65b220d979fbd652b34a60c4cfa58b7294b Mon Sep 17 00:00:00 2001
From: Sebastian Wagner <swagner@intevation.de>
Date: Fri, 17 Nov 2023 17:39:46 +0100
Subject: [PATCH] focus, modify view: make submit button default

reverse the order of button inputs (sumbit/OK first) in DOM, and thus
submit is the default on enter

to keep the order reversed when viewed (first cancel, then OK), reverse
the display with CSS

fixes moinwiki/moin#1559
---
 src/moin/themes/focus/static/css/theme.css  |  3 +++
 src/moin/themes/focus/templates/modify.html | 10 +++++-----
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/src/moin/themes/focus/static/css/theme.css b/src/moin/themes/focus/static/css/theme.css
index afea1fddd..0a82754bd 100644
--- a/src/moin/themes/focus/static/css/theme.css
+++ b/src/moin/themes/focus/static/css/theme.css
@@ -110,6 +110,9 @@ header a:visited, #top-bar a:visited { color: #242424; }
     padding: 0pt 6pt; }
 .moin-form .submit-buttons { display: flex; column-gap: 8pt; justify-content: end;
     margin: 12pt 0;
+    float: right;
+    display: flex;
+    flex-direction: row-reverse;
 }
 .moin-form button, .moin-form input[type="submit"] { clear: none; margin: unset; }
 .moin-form button, .moin-button, .moin-form input[type="submit"] { display: flex;
diff --git a/src/moin/themes/focus/templates/modify.html b/src/moin/themes/focus/templates/modify.html
index 4e4ac1b47..644ef29c0 100644
--- a/src/moin/themes/focus/templates/modify.html
+++ b/src/moin/themes/focus/templates/modify.html
@@ -73,14 +73,14 @@ <h1>{{ title }}</h1>
                         <button class="moin-button" type="button" >{{ _("Load Draft") }}</button>
                         {% set warning = _("Clicking this button will delete draft!") %}
                     {% endif %}
-                    {{ gen.input(type='submit', id='moin-cancel-text-button', name='cancel', value=form.cancel_label,
-                        class='moin-button moin-modify-submit negative', onclick="$('#moin-modify').removeClass('moin-changed-input')",
-                        title=warning) }}
+                    {{ gen.input(type='submit', id='moin-save-text-button', value=form.submit_label,
+                        class='moin-button moin-modify-submit', title=warning, tabindex='-1') }}
                     {{ gen.input(type='submit', id='moin-preview-text-button', name='preview', value=form.preview_label,
                         class='moin-button moin-modify-submit', onclick="$('#moin-modify').removeClass('moin-changed-input')",
                         title=warning) }}
-                    {{ gen.input(type='submit', id='moin-save-text-button', value=form.submit_label,
-                        class='moin-button moin-modify-submit', title=warning) }}
+                    {{ gen.input(type='submit', id='moin-cancel-text-button', name='cancel', value=form.cancel_label,
+                        class='moin-button moin-modify-submit negative', onclick="$('#moin-modify').removeClass('moin-changed-input')",
+                        title=warning) }}
                 </div>
 
             {% endif %}