Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and refactor synonyms, & their usage in template code #6

Open
waharnum opened this issue Feb 22, 2016 · 0 comments
Open

Rename and refactor synonyms, & their usage in template code #6

waharnum opened this issue Feb 22, 2016 · 0 comments

Comments

@waharnum
Copy link
Owner

'Syonyms' is a bad metaphor for the configuration file at https://github.com/waharnum/inlibraries.com/blob/master/synonyms.json - while it has some synonyms, it's more of a general random substitution lookup file.

The template code for the custom functions is also rather cruddy and excessively tied to the data structure of the file (which might also suck). It's perhaps better to flatten it from the standpoint of the template tags so that custom tags look something like this: {{ random_word_for("types_of_librarians" }}

This one needs some thinking. It also may eventually hit the point where there should be a back end DB or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant