Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: pubSubTopic not respected on createLightNode #1446

Closed
mfw78 opened this issue Jul 29, 2023 · 2 comments · Fixed by #1586
Closed

bug: pubSubTopic not respected on createLightNode #1446

mfw78 opened this issue Jul 29, 2023 · 2 comments · Fixed by #1586
Assignees
Labels
bug Something isn't working

Comments

@mfw78
Copy link

mfw78 commented Jul 29, 2023

This is a bug report

Problem

When trying to initialise a node object in Javascript, the pubSubTopic parameter isn't being used to configure the pubSubTopic. This appears to be a regression with the most recent release.

Code example:

	const waku = await createLightNode({
		defaultBootstrap: false,
		libp2p: {
			peerDiscovery: [bootstrap({ list: BOOTSTRAP_LIST })],
		},
		pubSubTopic: "/waku/2/dev-waku/proto",
	});

Then, when conducting a simple ping-pong test, the nwaku node that was in BOOTSTRAP_LIST indicates:

INF 2023-07-29 07:20:03.757+00:00 received filter subscribe request          topics="waku filter" tid=1 file=protocol.nim:110 peerId=12D*tk5oPx request="(requestId: \"fca4ad27-1ce0-4bfb-81a9-62797f4f5368\", filterSubscribeType: SUBSCRIBE, pubsubTopic: some(\"/waku/2/default-waku/proto\"), contentTopics: @[\"/swarm-waku/1/pong/proto\"])"

The actual behaviour that I expect is that the pubsubTopic should be set to /waku/2/dev-waku/proto.

Proposed Solutions

pubsubTopic is respected.

Notes

  • js-waku: "@waku/sdk": "^0.0.16", "@waku/interfaces": "^0.0.15"
  • Environment: browser (firefox)
  • Nodes connected to: local nwaku v0.0.18
@fryorcraken fryorcraken added this to Waku Jul 29, 2023
@fryorcraken fryorcraken added the bug Something isn't working label Jul 31, 2023
@fryorcraken
Copy link
Collaborator

Cc @danisharora099 who is looking at static sharding

@danisharora099
Copy link
Collaborator

@mfw78 can you please share reproducible code? #1586 should address this bug

@fryorcraken fryorcraken moved this from Priority to In Progress in Waku Sep 21, 2023
@danisharora099 danisharora099 moved this from In Progress to Code Review / QA in Waku Sep 22, 2023
@github-project-automation github-project-automation bot moved this from Code Review / QA to Done in Waku Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants