Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make CI / node mandatory again #1588

Closed
weboko opened this issue Sep 21, 2023 · 1 comment
Closed

chore: make CI / node mandatory again #1588

weboko opened this issue Sep 21, 2023 · 1 comment

Comments

@weboko
Copy link
Collaborator

weboko commented Sep 21, 2023 •
edited
Loading

This is a change request

Problem

After PR #1566 CI/node step is not mandatory but we keep an agreement not to merge stuff while it is failing.

We need to make it mandatory by default.

Proposed Solutions

It happens due to other repos re-using js-waku interop tests. Maybe using another way to enable such reusability will fix the issue. Or just return the required check later on.
@fryorcraken fryorcraken added this to Waku Sep 21, 2023
@weboko
Copy link
Collaborator Author

weboko commented Sep 21, 2023

@fryorcraken enabled setting again

@weboko weboko closed this as completed Sep 21, 2023
@github-project-automation github-project-automation bot moved this to Done in Waku Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weboko