Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter subscribe on 2 different nwaku nodes doesn't work reliable #1606

Closed
Tracked by #1463
fbarbu15 opened this issue Sep 22, 2023 · 4 comments
Closed
Tracked by #1463

Filter subscribe on 2 different nwaku nodes doesn't work reliable #1606

fbarbu15 opened this issue Sep 22, 2023 · 4 comments
Labels
bug Something isn't working E:2.1: Production testing of existing protocols See https://github.com/waku-org/pm/issues/49 for details

Comments

@fbarbu15
Copy link
Collaborator

fbarbu15 commented Sep 22, 2023

This is a bug report

Problem

  • Have a js-waku ligh node and 2 nwaku nodes.
  • From js-waku create 2 filter subscription objects, one for each nwaku node.
  • Send messages for both subscriptions.

50% of the time the message send for the 2nd subscription is lost

I tested this by having the DefaultPubSubTopic on both nwaku nodes but also having different pubSubTopics (in the context of static sharding) and the issue reproduces in both cases.

I have a test that reproduces the issue here. Test fails 50% of the time at expect(await messageCollector.waitForMessages(2)).to.eq(true); because only the 1st message is detected. In order to reproduce this you need to disable the mocha retry mechanism from .mocharc

@fbarbu15 fbarbu15 added the bug Something isn't working label Sep 22, 2023
@fbarbu15 fbarbu15 added this to Waku Sep 22, 2023
@fbarbu15
Copy link
Collaborator Author

Same issue with Store protocol

@fryorcraken
Copy link
Collaborator

fryorcraken commented Oct 9, 2023

Will be done as part of #1463

@danisharora099
Copy link
Collaborator

part of #1463

@danisharora099 danisharora099 moved this to To Do in Waku Oct 17, 2023
@fryorcraken fryorcraken added the E:2.1: Production testing of existing protocols See https://github.com/waku-org/pm/issues/49 for details label Oct 25, 2023
@chair28980
Copy link
Contributor

Closing in favor #1463

@github-project-automation github-project-automation bot moved this from To Do to Done in Waku Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working E:2.1: Production testing of existing protocols See https://github.com/waku-org/pm/issues/49 for details
Projects
Archived in project
Development

No branches or pull requests

4 participants