Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: investigate transition to EventTarget #1737

Open
Tracked by #337
weboko opened this issue Nov 28, 2023 · 0 comments
Open
Tracked by #337

feat: investigate transition to EventTarget #1737

weboko opened this issue Nov 28, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@weboko
Copy link
Collaborator

weboko commented Nov 28, 2023

This is a feature request

Problem

Right now js-waku uses EventEmitter from @libp2p/interface/events which increases amount of dependencies and potentially leading to increased bundle.

Proposed Solutions

Browsers have EventTarget built in and it is straightforward to use like here

Notes

As @danisharora099 highlighted in this comment there are some advantages of using it.
@weboko weboko added this to Waku Nov 28, 2023
@weboko weboko added the enhancement New feature or request label Nov 28, 2023
This was referenced Nov 28, 2023
Open
Closed
@chair28980 chair28980 moved this to To Do in Waku Nov 28, 2023
@weboko weboko changed the title feat: investigate movement to EventTarget feat: investigate transition to EventTarget Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Waku
Status: To Do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weboko