Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove support for named sharding (setting pubsub topic manually) #1775

Open
adklempner opened this issue Jan 8, 2024 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@adklempner
Copy link
Member

This is a feature or change request

Problem

With #1751 , named sharding will be deprecated. We continue to allow setting the pubsub topic manually to prevent breaking changes and give users time to transition to static or auto sharding. Eventually this needs to be completely removed.

Proposed Solutions

Once all relevant documentation and examples are updated, and we verify that major stakeholders have transitioned away from named sharding, remove all instances of pubsubTopic that were marked as deprecated and update any functions accordingly.

Notes

@fryorcraken fryorcraken added this to Waku Jan 8, 2024
@chair28980 chair28980 added enhancement New feature or request E:1.2: Autosharding for autoscaling See https://github.com/waku-org/pm/issues/65 for details labels Jan 10, 2024
@chair28980 chair28980 moved this to To Do in Waku Jan 10, 2024
@adklempner adklempner moved this from To Do to Icebox in Waku Jan 31, 2024
@adklempner
Copy link
Member Author

Moving to icebox. As of now, Status is continuing to use named sharding for the near future so we should not remove it.

@chair28980 chair28980 removed the E:1.2: Autosharding for autoscaling See https://github.com/waku-org/pm/issues/65 for details label Jan 31, 2024
@chair28980
Copy link
Contributor

Item removed from Epic 1.2: waku-org/pm#65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Icebox
Development

No branches or pull requests

2 participants