Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve reuse of pubsub/content topic configuration #1814

Open
adklempner opened this issue Jan 25, 2024 · 5 comments
Open

feat: improve reuse of pubsub/content topic configuration #1814

adklempner opened this issue Jan 25, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@adklempner
Copy link
Member

adklempner commented Jan 25, 2024

This is a bug report/feature or change request/support request

Problem

The library consumer has to set the content/pubsub topic in multiple places:

  • when creating the waku node
  • when creating an encoder/decoder
  • when creating a subscription

If the three don't match, then it can lead to unwanted behaviour

Proposed Solutions

Notes

@danisharora099
Copy link
Collaborator

issue description is empty. moving this back to triage

@danisharora099 danisharora099 moved this from Priority to Triage in Waku Mar 7, 2024
@weboko
Copy link
Collaborator

weboko commented Mar 27, 2024

@adklempner could you, please, provide description and some examples of what this feature is about. If possible - link it to relevant epic or milestone

@weboko weboko moved this from Triage to Priority in Waku May 2, 2024
@weboko
Copy link
Collaborator

weboko commented May 2, 2024

Moving to priority as it is better to finalize before the next release.

@danisharora099
Copy link
Collaborator

@weboko are we set on the proposed solution? do we want to triage it before we tackle it?

@weboko weboko moved this from Priority to In Progress in Waku Jul 3, 2024
@weboko weboko self-assigned this Jul 3, 2024
@weboko weboko moved this from In Progress to Triage in Waku Jul 10, 2024
@weboko
Copy link
Collaborator

weboko commented Jul 10, 2024

Proposed solution:

  • drop pubsubTopic;
  • combine shardInfo and contentTopics under new property network or networkConfiguration;
  • add default export of TWN shardParams from @waku/*package and make them default in case defaultBootstrap is used;
  • add createEncoder and createDecoder as part of WakuNode to be used as follows:
const node = createLightNode({ defaultBootstrap: true });
const encoder = node.createEncoder({ ... }); // <- potentially by using some params asym/sym encoder/decoder can be instantiated
const decoder = node.createDecoder({ ... });

@weboko weboko moved this from Triage to Priority in Waku Jul 11, 2024
@weboko weboko moved this from Priority to To Do in Waku Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To Do
Development

No branches or pull requests

4 participants