Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create a new package @waku/discovery to encapsulate all discovery mechanisms available within Waku #1862

Closed
3 tasks
danisharora099 opened this issue Feb 26, 2024 · 0 comments · Fixed by #1876
Assignees
Labels
enhancement New feature or request

Comments

@danisharora099
Copy link
Collaborator

danisharora099 commented Feb 26, 2024

This is a feature request

Problem

We currently have 3 discovery options available within Waku:

For this, we have 3 separate packages, which might only increase with time.

Proposed Solutions

Create a generalised package @waku/discovery to encapsulate all the available discovery mechanisms.

Acceptance Criteria

  • Deprecate @waku/peer-exchange, @waku/dns-discovery, @waku/local-peer-cache
  • Create @waku/discovery
  • Export Peer Exchange, DNS Discovery, Local Peer Cache from @waku/discovery
@danisharora099 danisharora099 self-assigned this Feb 26, 2024
@fryorcraken fryorcraken added this to Waku Feb 26, 2024
@chair28980 chair28980 added the enhancement New feature or request label Feb 28, 2024
@chair28980 chair28980 moved this to To Do in Waku Feb 28, 2024
@danisharora099 danisharora099 moved this from To Do to In Progress in Waku Mar 1, 2024
@danisharora099 danisharora099 moved this from In Progress to Code Review / QA in Waku Mar 5, 2024
@github-project-automation github-project-automation bot moved this from Code Review / QA to Done in Waku Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants