Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove autosharding tests skip mechanism when the CI uses nwaku 0.27.0 #1922

Closed
fbarbu15 opened this issue Mar 18, 2024 · 5 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@fbarbu15
Copy link
Collaborator

This is a change request

Nwaku will start supporting autosharing on all clusters starting with 0.27.0
When that happens and we update the js-waku CI to use 0.27.0 we can remove the autosharding tests skip mechanism
Ex: https://github.com/waku-org/js-waku/blob/master/packages/tests/tests/store/multiple_pubsub.spec.ts#L219-L223

@fbarbu15 fbarbu15 added the enhancement New feature or request label Mar 18, 2024
@fryorcraken fryorcraken added this to Waku Mar 18, 2024
@fbarbu15 fbarbu15 moved this to Blocked in Waku Mar 18, 2024
@weboko
Copy link
Collaborator

weboko commented Apr 22, 2024

@fbarbu15 can I assign it to you?

@fbarbu15
Copy link
Collaborator Author

Yes

@fbarbu15 fbarbu15 self-assigned this Apr 23, 2024
@weboko weboko moved this from Blocked to To Do in Waku Apr 24, 2024
@weboko
Copy link
Collaborator

weboko commented Apr 24, 2024

Seems to be unblocked as https://github.com/waku-org/nwaku/releases/tag/v0.27.0 is released.

@fbarbu15
Copy link
Collaborator Author

will look at this ASAP

@fbarbu15
Copy link
Collaborator Author

Closed as completed via 1975.

@github-project-automation github-project-automation bot moved this from To Do to Done in Waku Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants