Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): remove delays between dials #1977

Open
danisharora099 opened this issue Apr 25, 2024 · 2 comments
Open

fix(tests): remove delays between dials #1977

danisharora099 opened this issue Apr 25, 2024 · 2 comments
Labels
bug Something isn't working test Issue related to the test suite with no expected consequence to production code

Comments

@danisharora099
Copy link
Collaborator

This is a bug report

Problem

nwaku<>js-waku interop saw flakiness when we dial two nwaku nodes, from js-waku, one after the other -- the connections seems to be dropping.

adding a small delay of 500ms between the two dials seems to have fixed it -- https://github.com/waku-org/js-waku/pull/1973/files

Proposed Solutions

  1. Investigate why the delays needed to be add
  2. Remove the delays
@fryorcraken fryorcraken added this to Waku Apr 25, 2024
@danisharora099 danisharora099 added the bug Something isn't working label Apr 25, 2024
@weboko weboko moved this to Triage in Waku Apr 25, 2024
@weboko weboko added the test Issue related to the test suite with no expected consequence to production code label May 2, 2024
@weboko
Copy link
Collaborator

weboko commented May 2, 2024

Maybe @fbarbu15 has any input or ideas on it.

@weboko weboko moved this from Triage to To Do in Waku May 2, 2024
@fbarbu15
Copy link
Collaborator

Unfortunately no, I don't have any real clue what caused this flaky tests. Maybe a race condition?
gabrielmer discovered this issue/fix, maybe he knows more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Issue related to the test suite with no expected consequence to production code
Projects
Status: To Do
Development

No branches or pull requests

3 participants