Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fail when both pubsubTopics and shardInfo are specified #1980

Closed
vpavlin opened this issue Apr 25, 2024 · 2 comments · Fixed by #1959
Closed

chore: fail when both pubsubTopics and shardInfo are specified #1980

vpavlin opened this issue Apr 25, 2024 · 2 comments · Fixed by #1959
Assignees
@weboko
Labels
enhancement New feature or request

Comments

@vpavlin
Copy link
Member

vpavlin commented Apr 25, 2024

This is a change request

Problem

When setting up light node, users can specify both pubsubTopics and shardInfo which seems to result in unwanted behaviour

Proposed Solutions

Error out when both pubsubTopics and shardInfo are specified and suggest only one is provided

Notes
@fryorcraken fryorcraken added this to Waku Apr 25, 2024
@weboko weboko mentioned this issue Apr 29, 2024
Merged
@weboko weboko moved this to In Progress in Waku Apr 29, 2024
@weboko weboko added the enhancement New feature or request label Apr 29, 2024
@weboko weboko self-assigned this Apr 29, 2024
@weboko
Copy link
Collaborator

weboko commented Apr 29, 2024

Addressing it here - ensureShardingConfigured

@weboko
Copy link
Collaborator

weboko commented Apr 29, 2024

I jumped into conclusion that there is actually a problem - but after checking in one of my local examples or testing pipeline we have currently #1992 - there seems to be no error.

Of course I agree this shouldn't happen - and some warning should be printed.

@vpavlin please, share details what actually fails?

@weboko weboko changed the title Fail when both pubsubTopics and shardInfo are specified chore: fail when both pubsubTopics and shardInfo are specified Apr 29, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Waku Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weboko weboko

Labels
enhancement New feature or request
Projects
Waku
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: lift contentTopics and make shardInfo mandatory for createLight… waku-org/js-waku
2 participants
@vpavlin @weboko