Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filter)!: limit filter subscriptions to use a single decoder #1981

Closed
adklempner opened this issue Apr 25, 2024 · 2 comments
Closed

feat(filter)!: limit filter subscriptions to use a single decoder #1981

adklempner opened this issue Apr 25, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@adklempner
Copy link
Member

This is a bug report/feature request/support request/change request

Problem

The subscribe function for filter accepts either a single decoder or an array of decoders. This leads to a lot of overhead for the library consumer when handling the response: it might fail before even attempting a subscription, all subscriptions requests might fail, some might fail and some succeed, or all succeed. It's cleaner for the function to accept a single decoder and respond with a single failure or success.

Proposed Solutions

Refactor subscribe function in filter to only accept a single decoder

Notes

@weboko
Copy link
Collaborator

weboko commented May 2, 2024

This issue proposes a solution to the problem of ambiguity of error handling when we don't have fail or not fail which happens because of a need to provide support to multiple decoders.

@vpavlin @hackyguru do you think we should continue supporting ability to subscribe to multiple decoders?

@chair28980 chair28980 moved this from Triage to To Do in Waku May 8, 2024
@chair28980 chair28980 moved this from To Do to Blocked in Waku May 8, 2024
@weboko weboko moved this from Blocked to Triage in Waku Jun 5, 2024
@weboko
Copy link
Collaborator

weboko commented Jun 20, 2024

As we don't have clear vision on this one - let's postpone and make a change in scope of #2034 if needed.

Closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants