Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove the suffix SDK from user-facing protocol types #1998

Open
danisharora099 opened this issue May 7, 2024 · 0 comments
Open

chore: remove the suffix SDK from user-facing protocol types #1998

danisharora099 opened this issue May 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@danisharora099
Copy link
Collaborator

danisharora099 commented May 7, 2024 •
edited by chair28980
Loading

This is a support request

Problem

With our work on splitting protocol implementations to Core and SDK, we also introduced two types for each implementation class: <Protocol>Core and <Protocol>SDK

Based on some comments, we should reflect if this is the right naming convention to progress with.
(#1971 (comment))

Proposed Solutions

  • Have <Protocol> for SDK and <ProtocolCore> for Core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Waku
Status: To Do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chair28980 @danisharora099