We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This is a change request
For our compliance test:
js-waku/packages/tests/tests/peer-exchange/compliance.spec.ts
Lines 51 to 54 in 6f188ef
This is quite hacky, and seems to introduce some race conditions as brought up by @gabrielmer.
Use a more predictable logic that waits for peer-exchange to be mounted. Eg: peerExchange.isMounted/peerExchange.on("mounted")
peerExchange.isMounted
peerExchange.on("mounted")
The text was updated successfully, but these errors were encountered:
danisharora099
Successfully merging a pull request may close this issue.
This is a change request
Problem
For our compliance test:
js-waku/packages/tests/tests/peer-exchange/compliance.spec.ts
Lines 51 to 54 in 6f188ef
This is quite hacky, and seems to introduce some race conditions as brought up by @gabrielmer.
Proposed Solutions
Use a more predictable logic that waits for peer-exchange to be mounted.
Eg:
peerExchange.isMounted
/peerExchange.on("mounted")
The text was updated successfully, but these errors were encountered: