Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: understand how to map dns fleets for custom pubsub topics #2014

Closed
danisharora099 opened this issue May 14, 2024 · 6 comments
Closed

Comments

@danisharora099
Copy link
Collaborator

This is a change request

Problem

We currently either use the wakuv2.test fleet which runs DefaultPubsubTopic or the waku.sandbox fleet which runs TWN nodes.

We have no way to default bootstrap into the network for a custom pubsub topic.

Proposed Solutions

Understand if this is even needed.

If not, remove ability to defaultBootstrap on a custom pubsub topic that isn't either:

  • DefaultPubsubTopic
  • TWN

Notes

@weboko
Copy link
Collaborator

weboko commented May 17, 2024

Let's approach it from user flows that we can anticipate:

  • basic flow: user provides contentTopics and uses TWN;
  • basic flow(old but supported): usage of defaultPubsubTopic and any contentTopic;
  • sophisticated user: custom pubsubTopics with provided discovery nodes;

Based on that currently we support custom pubsub topics or default pubsub topics.
To me it seems that if a consumer wants to use custom - then there is no reason for them to use our default.

I propose to close this issue as there is no clear deliverable on it. @danisharora099

@LordGhostX can you, please, help understand if we have documented a way for user to uses custom pubsub topics?

@vpavlin do you have more insight into this? Precisely, if someone would need to use custom and default pubsub topics at the same time?

@LordGhostX
Copy link
Contributor

@weboko there's a PR for the docs showing how to use custom shard info with @waku/sdk: waku-org/docs.waku.org#193

@vpavlin
Copy link
Member

vpavlin commented May 21, 2024

Let me ask this - what is the difference between custom and default pubsub topics? Apart from "until js-waku works with TWN, we need to fallback to something else (particula default topic which has a fleet backing it).

Speaking of defaultBootstrap though - a user using custom pubsub might still want to leverage the default bootstrap for discovery (@jm-clius or not?) as the Metadata protocol and cluster-id is what should distinguish actual "clusters", but the discovery might be common across all/multiple clusters.

Althought I am also not sure this applies fully to js-waku since the peer discovery is limited to DNS (i.e. would be better for custom cluster to have their own enrtree) and peer-exchange (will TWN nodes give me non-TWN peers over peer-exchange?)

@jm-clius
Copy link

might still want to leverage the default bootstrap for discovery (@jm-clius or not?)

In theory, yes, although often bootstrap nodes themselves would filter entries from their discv5 routing table for pubsub topics that they do not subscribe to themselves. However, this is a configuration not a principle - the discovery network is independent from the pubsub topic networks and can be shared.

@danisharora099
Copy link
Collaborator Author

what is the difference between custom and default pubsub topics? Apart from "until js-waku works with TWN, we need to fallback to something else (particula default topic which has a fleet backing it).

difference I see is: we have a way to bootstrap into the network because we run nodes on DefaultPubsubTopic. Doing defaultBootstrap on a random pubsub topic won't find any nodes. But perhaps that's expected then.

@danisharora099
Copy link
Collaborator Author

Based on that currently we support custom pubsub topics or default pubsub topics.
To me it seems that if a consumer wants to use custom - then there is no reason for them to use our default.

I propose to close this issue as there is no clear deliverable on it.

Sounds good to me!

@github-project-automation github-project-automation bot moved this from Triage to Done in Waku May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

5 participants