-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: accept one filed for network configuration #2027
Comments
WDYT @weboko ? |
@vpavlin, what is the case for users to specify both |
No idea:) I think the case is specifying Consider this with assumption js-waku works with TWN:
The actual case is this change 5b03709 broke things that previously worked - i.e. contentTopic and pubsubTopic specified at once. Regardless of what the use case for having both |
I think this is something that is not clear and we need more feedback on it. For action point for this task I think we should refine My approach would be to:
Slightly intervened with #2034 |
pubsubTopics
This solution will be to complicated especially before we deprecate Adding simple throw for now - #2056 |
This is a bug report
Problem
When
contentTopics
is specified,options.shardInfo
will get populated here https://github.com/waku-org/js-waku/blob/master/packages/sdk/src/utils/libp2p.ts#L98If
shardInfo
is specified,pubsubTopics
get rewritten https://github.com/waku-org/js-waku/blob/master/packages/sdk/src/utils/libp2p.ts#L105Proposed Solutions
Either error out if both
shardInfo
andpubsubTopics
is populated, or do not overwritepubsubTopics
if they are explicitly definedThe text was updated successfully, but these errors were encountered: