Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove predefined list of nodes #2035

Closed
danisharora099 opened this issue Jun 6, 2024 · 0 comments · Fixed by #2025
Closed

chore: remove predefined list of nodes #2035

danisharora099 opened this issue Jun 6, 2024 · 0 comments · Fixed by #2025
Assignees
@danisharora099

Comments

@danisharora099
Copy link
Collaborator

This is a change request

Problem

We store multiaddrs for nodes from the deployed fleets hardcoded. This is unreliable, is our source of truth is the ENR Tree, and resolution of nodes should occur from the ENR Tree.

Proposed Solution

Remove the predfined list of nodes, and use the ENR Tree for resolution.
DNS module can be used for the resolution into multiaddresses.
@danisharora099 danisharora099 self-assigned this Jun 6, 2024
@danisharora099 danisharora099 mentioned this issue Jun 6, 2024
Merged
3 tasks
@fryorcraken fryorcraken added this to Waku Jun 6, 2024
@danisharora099 danisharora099 moved this to Code Review / QA in Waku Jun 6, 2024
@github-project-automation github-project-automation bot moved this from Code Review / QA to Done in Waku Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danisharora099 danisharora099

Labels
None yet
Projects
Waku
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: failing node_optional check waku-org/js-waku
1 participant
@danisharora099