Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(peer-exchange): support updates of previously discovered peer's addresses #2051

Closed
danisharora099 opened this issue Jun 28, 2024 · 1 comment · Fixed by #2088
Closed
Assignees

Comments

@danisharora099
Copy link
Collaborator

This is a potential bug report

Problem

Based on waku-org/go-waku#1128, it was found out that status-go runs into a problem where if a peer is discovered dynamically, perhaps using Peer Exchange, the peer is stored in the Peer Store with certain TTL. In case the peer is discovered again, in case with updated addresses, it is discarded because we assume that we already have knowledge about its information, but the addresses might be refreshed.

Proposed Solutions

Account for the change of addresses observed, when the same peer is discovered again in Peer Exchange

@danisharora099 danisharora099 added the bug Something isn't working label Jun 28, 2024
@fryorcraken fryorcraken added this to Waku Jun 28, 2024
@weboko weboko moved this to Triage in Waku Jul 2, 2024
@weboko weboko moved this from Triage to Priority in Waku Jul 3, 2024
@danisharora099 danisharora099 moved this from Priority to In Progress in Waku Jul 24, 2024
@danisharora099 danisharora099 self-assigned this Jul 24, 2024
@weboko
Copy link
Collaborator

weboko commented Jul 24, 2024

Part of Reliability milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants