You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have different utils being setup for different tests, specifically protocols. This, in places, is starting to get redundant and would be good to keep /tests/ folder strictly spec files while all utils can live in /src/ instead (along with other utils)
stop using createLightNode/createRelayNode directly and instead create createTestLightNode/createTestRelayNode util that will be configured for DefaultTestShardInfo and other test defaults;
remove runNode/runStoreNode/runNodeBuilder/runNodes utils in favor of one and do not pass any shardInfo as it defaults to DefaultTestShardInfo;
remove all custom const PubsubTopics/ShardInfo etc and use only DefaultTestShardInfo/DefaultTestPubsubTopic;
This is a change request
Problem
We have different utils being setup for different tests, specifically protocols. This, in places, is starting to get redundant and would be good to keep
/tests/
folder strictlyspec
files while all utils can live in/src/
instead (along with other utils)Proposed Solutions
Abstract away different utils like https://github.com/waku-org/js-waku/blob/master/packages/tests/tests/filter/utils.ts and
js-waku/packages/tests/tests/store/utils.ts
Line 103 in 04bd518
/src
perhaps)Notes
The text was updated successfully, but these errors were encountered: