Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix dispatchEvent test #1897

Merged
merged 2 commits into from
Mar 9, 2024
Merged

test: fix dispatchEvent test #1897

merged 2 commits into from
Mar 9, 2024

Conversation

fbarbu15
Copy link
Collaborator

@fbarbu15 fbarbu15 commented Mar 8, 2024 •
edited
Loading

  1. Fix and unskio connectionManager.dispatchEvent according to update connectionManager.dispatchEvent test to listen to correct events #1835 (comment)
  2. Fix port overflow error
  3. Skipped flaky test that I just couldn't reliably fix in CI although it works fine locally

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 185.24 KB (0%) 3.8 s (0%) 16 s (-19.02% 🔽) 19.7 s
Waku Simple Light Node 185.17 KB (0%) 3.8 s (0%) 17.3 s (+56.64% 🔺) 21 s
ECIES encryption 22.89 KB (0%) 458 ms (0%) 4.3 s (+37.06% 🔺) 4.7 s
Symmetric encryption 22.34 KB (0%) 447 ms (0%) 3.8 s (+37.14% 🔺) 4.2 s
DNS discovery 69.95 KB (0%) 1.4 s (0%) 8.3 s (+11.62% 🔺) 9.7 s
Privacy preserving protocols 39.84 KB (0%) 797 ms (0%) 5.6 s (-21.93% 🔽) 6.4 s
Light protocols 20.58 KB (0%) 412 ms (0%) 4.3 s (+3.63% 🔺) 4.8 s
History retrieval protocols 19.34 KB (0%) 387 ms (0%) 4 s (+7.12% 🔺) 4.3 s
Deterministic Message Hashing 4.96 KB (0%) 100 ms (0%) 1.3 s (+57.85% 🔺) 1.4 s

@fbarbu15 fbarbu15 marked this pull request as ready for review March 8, 2024 18:27
@fbarbu15 fbarbu15 requested a review from a team as a code owner March 8, 2024 18:27
danisharora099
danisharora099 approved these changes Mar 9, 2024
View reviewed changes
Copy link
Collaborator

@danisharora099 danisharora099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/tests/tests/peer-exchange/query.spec.ts
@@ -123,7 +123,8 @@ describe("Peer Exchange Query", function () {
await tearDownNodes([nwaku1, nwaku2, nwaku3], waku);
});

it("connected peers and dial", async function () {
// slow and flaky in CI
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's open an issue to track this please

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've opened this one

@danisharora099 danisharora099 merged commit 36dfcc9 into master Mar 9, 2024
11 of 12 checks passed
@danisharora099 danisharora099 deleted the test/dispatchEvent-test-fix branch March 9, 2024 22:40
@danisharora099 danisharora099 mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danisharora099 danisharora099 danisharora099 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbarbu15 @danisharora099