Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec about the floor-plan #154

Closed
zerg000000 opened this issue Apr 3, 2019 · 4 comments
Closed

Spec about the floor-plan #154

zerg000000 opened this issue Apr 3, 2019 · 4 comments

Comments

@zerg000000
Copy link

I hit several times that, making change to floor plan cause a lot of un-obvious exceptions. like emitter is mandatory, some options if defined, it must have at least one item. I think a spec maybe useful in this case, make the user experience much better.

@myguidingstar
Copy link
Contributor

sorry for the experience. I totally agree. The problem is floor plan is quite big, and I've split the processing pipeline into quite a few smaller functions. I guess it will work with spec2's select so I am kinda waiting. Without spec2/select, the number of specs can be tremendously large.
That being said, it's still valuable to spec as many of them as possible.

@zerg000000
Copy link
Author

I am totally okay to wait for spec2, as I am waiting for spec2 too.

@myguidingstar
Copy link
Contributor

New public api has been merged to master. I found a way around with spec1. The public api is simpler, floor-plan now becomes an internal thing.

@myguidingstar
Copy link
Contributor

to give feedback on errors, guardrails will be used. #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants