Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ScalarWidget #247

Open
Ingvord opened this issue May 19, 2020 · 0 comments
Open

Refactor ScalarWidget #247

Ingvord opened this issue May 19, 2020 · 0 comments

Comments

@Ingvord
Copy link
Member

Ingvord commented May 19, 2020

ScalarWidget MUST receive DataSource (Observable) and subscribe to it:

class ScalarWidget extends WaltzWidget {
  /**
  * @param {Observable<DataSource>} dataSource
  */
  constructor(dataSource, /*...*/){
     super(/*...*/)
     this.dataSource = dataSource;

     this.dataSource.subscribe(data => this.view.update(data))
  }

  /**
   * @return {webix.ui} this widgets UI
   */
  get view(){
     return $$(/*...*/);
  }
}

In the future all low level widgets should follow this pattern

Requires #246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant