Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Malformed Docker Registry URL fails silently #6

Open
cpitkin opened this issue Jul 1, 2019 · 0 comments
Open

Malformed Docker Registry URL fails silently #6

cpitkin opened this issue Jul 1, 2019 · 0 comments
Assignees
@cpitkin
Labels
bug

Comments

@cpitkin
Copy link
Contributor

cpitkin commented Jul 1, 2019

Issue summary:
Malformed by leaving out the //
DOCKER_REGISTRY_URL = 'https:335883679137.dkr.ecr.us-west-2.amazonaws.com/wearefine/base_ruby'

Code:
The error occurs on this line: https://github.com/wearefine/rails-jenkins-shared-libraries/blob/master/vars/railsDocker.groovy#L31

Proposed fix:
Check that the URL has the correct format when checking for the presence of the value
@cpitkin cpitkin added the bug label Jul 1, 2019
@cpitkin cpitkin self-assigned this Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpitkin cpitkin

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cpitkin