-
-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: patched mimalloc to use MADV_DONTNEED
than MADV_FREE
on Linux
#9037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 Benchmark detail: Open
|
CodSpeed Performance ReportMerging #9037 will not alter performanceComparing Summary
|
chenjiahan
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use patched mimalloc to use
MADV_DONTNEED
instead ofMADV_FREE
on reseting memory.This also takes effect on macOS.
While
MADV_FREE
is faster thanMADV_DONTNEED
, it does not affect theRSS
asMADV_DONTNEED
does.To reiterate, using
MADV_DONTNEED
means process-level memory statistics like RSS will be moreaccurately reflect the amount of physical memory being used by rspack.
Even this does not show any evidence that it would cause OOM issues, the fact seems stay the opposite
with reported incidents in go. GoLang team and many have encountered this issue and have reverted the option to
MADV_DONTNEED
in golang/go#42330.Rspack uses mimalloc for memory management.

The default strategy of mimalloc@2 is to purge the memory instead of reseting them.
However, in some cases, it would still reset memory (mi_free_block_mt, freeing blocks multi-thread):
With this patch,

MADV_FREE
is replaced withMADV_DONTNEED
:Related: microsoft/mimalloc#776
Rspack related: #8976
Checklist