Skip to content

Commit

Permalink
feat(MeetingsSdkAdapter): add browser default speaker to the availabl…
Browse files Browse the repository at this point in the history
…e speaker list
  • Loading branch information
patricia0817 authored and cipak committed Nov 19, 2021
1 parent 6d1d84a commit e149789
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/MeetingsSDKAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ export default class MeetingsSDKAdapter extends MeetingsAdapter {
state: MeetingState.NOT_JOINED,
cameraID: null,
microphoneID: null,
speakerID: null,
speakerID: '',
})),
// if not provided by the sdk, compute a meeting title
concatMap((meeting) => (
Expand Down
2 changes: 1 addition & 1 deletion src/MeetingsSDKAdapter.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ describe('Meetings SDK Adapter', () => {
state: 'NOT_JOINED',
cameraID: null,
microphoneID: null,
speakerID: null,
speakerID: '',
});
done();
});
Expand Down
1 change: 1 addition & 0 deletions src/MeetingsSDKAdapter/controls/SwitchSpeakerControl.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export default class SwitchSpeakerControl extends MeetingControl {
value: speaker.deviceId,
label: speaker.label,
}))),
map((options) => ([{value: '', label: 'Browser Default'}, ...options])),
);

return combineLatestImmediate(speakerID$, options$).pipe(
Expand Down
4 changes: 4 additions & 0 deletions src/MeetingsSDKAdapter/controls/SwitchSpeakerControl.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ describe('Switch Speaker Control', () => {
tooltip: 'Speaker Devices',
noOptionsMessage: 'No available speakers',
options: [
{
value: '',
label: 'Browser Default',
},
{
value: 'default',
label: 'Default - Headset Earphone (Jabra EVOLVE 20 SE MS) (0b0e:0300)',
Expand Down

0 comments on commit e149789

Please sign in to comment.