Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework VisibilityColumnConsideringSQLFilterTest #9

Open
janopae opened this issue Apr 17, 2021 · 0 comments
Open

Rework VisibilityColumnConsideringSQLFilterTest #9

janopae opened this issue Apr 17, 2021 · 0 comments

Comments

@janopae
Copy link
Member

janopae commented Apr 17, 2021

The VisibilityColumnConsideringSQLFilterTest is currently built as a heavy integration test, with a simulated Symfony Kernel and stuff. This on the one hand complicates the setup process - we need to simulate a request to get the filter activated. It also obscures the exact testing conditions, e.g. which FilterStrategy is used.

Also, working around the Doctrine caching could be solved by porting it to our webfactory/doctrine-orm-test-infrastructure.

Also, each test performing multiple assertions could be split.

Also, OneToOne-Relationships are currently only tested with EAGER-Loading - this detail is not visible from the Test case, but hidden in the test entity. Different tests for EAGER and LAZY for documenting the different effects the visibility filter has on each one of them would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant