Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split TranslatablePropertyValueHandler #3

Closed
mmenozzi opened this issue Jan 27, 2020 · 2 comments
Closed

Split TranslatablePropertyValueHandler #3

mmenozzi opened this issue Jan 27, 2020 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mmenozzi
Copy link
Member

The TranslatablePropertyValueHandler currently sets property value on both ProductVariantTranslation and ProductTranslation.

Given the fact that there could be more than one value handler for each Akeneo value, it should be split into two separate value handlers: ProductTranslationPropertyValueHandler and ProductVariantTranslationPropertyValueHandler.
@mmenozzi mmenozzi added help wanted Extra attention is needed enhancement New feature or request labels Jan 27, 2020
@lruozzi9
Copy link
Member

@mmenozzi is this issue still open? I mean: are we sure we want to split the value handler? The current implementation with the PropertyAccessor looks good to me.

@mmenozzi
Copy link
Member Author

I don't remember what was the issue here. I'm going to close this.

@mmenozzi mmenozzi closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmenozzi @lruozzi9