Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is still needed for the 1.4.5 release & will there be a 1.4.6 for EE 10? #9

Closed
jbisotti opened this issue Mar 12, 2023 · 11 comments
Assignees

Comments

@jbisotti
Copy link

We have a legacy project that still uses Struts 1.x heavily. Other aspects of the project have been updated and as part of that we want to move from Tomcat 8.5+Spring 5.3.x to Tomcat 10+Spring 6.x but Struts 1.x is holding us back. I just came across this project and am impressed to see all the modernization you've done. What are you plans going forward with this project? If possible, I'd love to use this but EE 10 is what we need.

@ste-gr
Copy link
Member

ste-gr commented Mar 12, 2023

Hi! I'm currently working to modernize and update to EE 9 of "commons-chain" and "tiles-request-servlet". This two dependencies are needed by Struts1.
I think, the upgrade from EE9 to EE10 is then more or less easy.

Currently the roadmap looks like this:

  • commons-chain (wip)
    • Upgrade to current maven-plugin-versions (done)
    • Upgrade to JDK-8 (i.e. add generics) (nearly done)
    • Upgrade JUnit3 to JUnit5 (open)
    • Split to sub-projects (open)
    • Add sub-project for EE 9 (open)
    • Change commons-logging to slf4j (open)
  • tiles-request-servlet (open)
    • Copy and upgrade to EE 9
    • Upgrade JUnit4 to JUnit5
  • struts1 - EE9 (wip)
    • Upgrade EE 8 to EE 9 (done)
    • Integrate upgraded dependencies commons-chain and tile-request-servlet
    • Update documentation
  • struts1 - EE10 (open)
    • Upgrade EE 9 to EE 10
    • Add module-info.javas
    • Update documentation

Of course, help is always welcome.

@ste-gr ste-gr self-assigned this Mar 12, 2023
@jbisotti
Copy link
Author

If I were to find some time to help, what would you suggest I look into first?

@ste-gr
Copy link
Member

ste-gr commented Mar 24, 2023

Hi, sorry for my late reply (vacation). I'll prepare all necessary dependencies and maybe you can extend it with

  • set groupId to io.github.weblegacy
  • jakarta-namespace like commons-fileupload2 with jaksrvlt as package-part-name
  • at least set automatic-module-name

Dependencies:

I think this could be a fast way to the new struts1-version.

Or maybe you have a better idea, it would be fine to discuss it.

Greetings
Stefan

@jo-kl
Copy link
Collaborator

jo-kl commented May 24, 2023

Hi, I would also like to contribute to this project to get the EE10 version ready as soon as possible.
What is the current status? Are there any subtasks I could work on to help you?

@ste-gr
Copy link
Member

ste-gr commented May 24, 2023

Hi @jo-kl,
thank you for helping me. Currently there are 3 blocking dependencies:

  • commons-chain
  • commons-fileupload
  • tiles-request

On commons-chain I'm currently working and I think I'm nearly ready.
At commons-fileupload and tiles-request adaptions for the jakarta-namespace are missing. Maybe you could make work on one (or two ;-)) of them. Please see me change-suggestions above.

Greetings
Stefan

@jo-kl
Copy link
Collaborator

jo-kl commented May 25, 2023

Hi Stefan,
I have already cloned both repos but have questions regarding your change suggestions.
Maybe we could have a short meeting and discuss the topics? How can we get in contact? I couldn't find your email address...

@ste-gr
Copy link
Member

ste-gr commented May 31, 2023

Hi @jo-kl,

did you received my mail from last week?

Greetings
Stefan

@lukamalovic
Copy link
Collaborator

Hi Stefan,

I'd also like to contribute towards getting this update completed. What's the status of it, are there any tasks available to work on?

Thanks,
Luka

@ste-gr
Copy link
Member

ste-gr commented Sep 24, 2023

Hi Luka,

thank you for your contribution-offer.

Currently it has the following status:

  • I have started to change the namespaces from javax to jakarta.
  • Unfortunately, the following dependencies are not yet JEE9+ compatible:
    • commons-fileupload (there is now version 2, which is JEE9+ compatible) - Open Task: Adapt Struts1 to version 2.0.0-M1.
    • commons-chain (I'm working on this right now, very old)
    • tiles-request-servlet (I still want to have a look at the current solution, write a small doc and then publish it) - Open Tasks: Write short doc/README

Nice to have, but not necessary:

Greetings
Stefan

@ste-gr
Copy link
Member

ste-gr commented Nov 6, 2023

Hi @jbisotti, @lukamalovic, @jo-kl,

🎉 🎉 great news! 🎉 🎉

The Struts1-Version 1.5.0-SNAPSHOT is ready for Jakarta-Namespace!

What is needed for the local-version:

  1. tiles-request-jakarta-servlet
    mvn clean install
  2. struts1
    mvn -Pdormant clean install

Now I will work on to release struts1 and tiles-request-jakarta-servlet. But in the meantime you could test this version with your applications.

Good luck with testing,
Greetings
Stefan

@ste-gr
Copy link
Member

ste-gr commented Dec 28, 2023

Hi @jbisotti, @lukamalovic, @jo-kl,

the Struts1-Version ready for Jakarta-Namespace (JEE9+) has been released (Version 1.5.0-RC1)!

Greetings
Stefan

@ste-gr ste-gr closed this as completed Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants