🚌 time off by an hour on planck

[stephenyeargin]

Betting it is a DST bug. Works on My Machine™, of course.

Above screenshot taken at 3:40. Actual arrival is 3:55, not 4:55.

/cc @jameswhite

[jameswhite]

Shopify/dashing#398

[stephenyeargin]

We used to bring in ActiveSupport to get some better timezone/DST handling, but that was stripped out to make the dashboards able to run on Flynn. Dunno if we bootstrap that back in, but wanted to note that this particular issue isn't 🆕. It was broken before the countdown was introduced.

I had attempted to fix it with:

dashboards-bikeshed/lib/nextbus.rb

Lines 28 to 34 in 8758052

	# Ugly hack to avoid using ActiveSupport
	timezone_offset = DateTime.now.offset.to_s == '-5/24' ? '-05:00' : '-06:00'
	{
	countdown: DateTime.parse('today at ' + data['next']['arrival_time'] + timezone_offset),
	moreinfo: "Route ##{data['route']['route_id']} / " \
	"#{data['route']['route_long_name']} leaves from #{data['stop_name']}"
	}

That didn't fix it.

[stephenyeargin]

Definitely related to the time change, as it is currently working.