Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playlist: allow other playlist providers #55

Open
clementdevos opened this issue Jun 24, 2020 · 1 comment
Open

Playlist: allow other playlist providers #55

clementdevos opened this issue Jun 24, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@clementdevos
Copy link
Contributor

Today we use the open.spotify link as a link for an iframe.
We could add more services by changing the parsing/validation function of the Edit Dialog component (https://github.com/welovedevs/react-ultimate-resume/blob/develop/src/package/components/cards/cards_types/soundtrack/edit_dialog/soundtrack_card_edit_dialog.jsx)

Deezer, youtube music, could be added.
@clementdevos clementdevos added enhancement New feature or request good first issue Good for newcomers labels Jun 24, 2020
vincent-boulin pushed a commit to vincent-boulin/react-ultimate-resume that referenced this issue Feb 24, 2022
✨ welovedevs#55 Permit to provide differents playlist provider
2b8a064
vincent-boulin pushed a commit to vincent-boulin/react-ultimate-resume that referenced this issue Feb 24, 2022
🐛 welovedevs#55 Change field description
76b23f4
vincent-boulin pushed a commit to vincent-boulin/react-ultimate-resume that referenced this issue Feb 24, 2022
🐛 welovedevs#55 Authorize higher maximum value due to soundcloud url
58f5000
clementdevos added a commit that referenced this issue Mar 2, 2022
@clementdevos
Merge pull request #101 from vincent-boulin/develop
b74b3f4 
[Enhancement #55] Allow 2 new player providers
@amerjasmeen
Copy link

This is good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clementdevos @amerjasmeen