Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: support disabling of the font-subset in header #458

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Nizzlay
Copy link

@Nizzlay Nizzlay commented Jan 8, 2025

Summary

I've created my own custom skin, that doens't use custom font, so I added a way to disable the font-subset.

Related issue

Changes

  • Added setting for subset_enabled, which is set to true by defaults
  • Amended logic in header.html to check if the subset is enabled
  • Updated mastering-tabi-settings blogpost (English version)

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have updated config.toml in tabi-start
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@Nizzlay Nizzlay requested a review from welpo as a code owner January 8, 2025 20:43
Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit 44d12d8
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/677ee357b8b01400084eeda3
😎 Deploy Preview https://deploy-preview-458--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@welpo
Copy link
Owner

welpo commented Jan 8, 2025

I like the idea. I'll try to improve the docs (translations + Custom Subset docs) before next Monday and merge.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants