Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Source #69

Closed
10 tasks done
robinmanuelthiel opened this issue May 16, 2023 · 4 comments
Closed
10 tasks done

Open Source #69

robinmanuelthiel opened this issue May 16, 2023 · 4 comments
Assignees

Comments

@robinmanuelthiel
Copy link
Member

robinmanuelthiel commented May 16, 2023

  • Add Docusaurus Docs
  • Add Pipeline to publish Docs to GitHub pages
  • Clean from all potentially checked-in secrets (check in GitGuardian)
  • Check issues if they have any security-relevant or embarrassing information
  • Short description in README
  • Quick "Getting Started" in README with way to download package and init (if required)
  • Link to documentation in README
  • Add MIT license
  • Update Release Pipelines to public NuGet/NPM feeds
  • Semantic Versioning starting at v1.0.0
@robinmanuelthiel robinmanuelthiel self-assigned this May 16, 2023
@robinmanuelthiel
Copy link
Member Author

robinmanuelthiel commented May 16, 2023

Blocked by #70

@robinmanuelthiel robinmanuelthiel added the blocked Blocked by other tasks or issues label May 16, 2023
@SebastianKuesters
Copy link
Member

@robinmanuelthiel there were two actions for some reason concurrent, which leads to the failing. After re-run it worked, you can continue

@robinmanuelthiel robinmanuelthiel removed the blocked Blocked by other tasks or issues label May 16, 2023
@robinmanuelthiel
Copy link
Member Author

Don't hink its two actions. It happens again. #79

Could it be, that the tests can't be run in parallel?

@robinmanuelthiel robinmanuelthiel mentioned this issue May 16, 2023
2 tasks
@robinmanuelthiel
Copy link
Member Author

@SebastianKuesters, I think I fixed it by not allowing the tests to run in parallel.

see 149e74c
and https://docs-internal.wemogy.com/general/conventions/languages/dotnet#parallelism

Anyway, although it fixes it for now, I would argue that this is a clean-code antipattern. Tests should be totally independent of each other and not rely on each other's orders or parallelism of execution. Also, I think that many test that are in the *.UnitTests projects are actually integration tests. I created an issue for cleaning the tests in the future: #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants