Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a clean git history? #120

Open
nileshpatra opened this issue Feb 22, 2020 · 11 comments
Open

Make a clean git history? #120

nileshpatra opened this issue Feb 22, 2020 · 11 comments

Comments

@nileshpatra
Copy link
Contributor

nileshpatra commented Feb 22, 2020

Currently the git history seems very cluttered, making it difficult to keep a track of changes.
For example ; this, this, this et. al.

IMO, smaller changes can be squashed to get a sane git history.

@xandao-dev
Copy link
Collaborator

Thank you for the feedback! I will improve my commits.

@xandao-dev
Copy link
Collaborator

Future commits will be squashed before the PR.
@rpotter12

@nileshpatra
Copy link
Contributor Author

nileshpatra commented Feb 23, 2020

@xandao6 why was the issue closed?
I think I wasn't clear, apologies.
What I mean was: we can squash some of the unrelated previous commits which you or other authors have made, and force-push?

There are ~300 commits for ~500 lines of code, which doesn't look good.

@xandao-dev xandao-dev reopened this Feb 23, 2020
@xandao-dev xandao-dev added the hard advance issue label Mar 1, 2020
@Pihu1998
Copy link

Pihu1998 commented Mar 8, 2020

Hey, I would like to work on this issue. Can I be assigned this issue?

@nileshpatra
Copy link
Contributor Author

@Pihu1998 it's probably on us, instead of participants.
We need to squash + force-push, and force-push would mean maintainer access to the repository.

A PR can only update the repository by placing commits on top, and not change the order of commits set earlier.

@Pihu1998
Copy link

Pihu1998 commented Mar 9, 2020

Oh, I get it now. Thanks for the information. :D

@xandao-dev xandao-dev removed gssoc21 hard advance issue labels Mar 12, 2020
@priyansh19
Copy link
Contributor

@xandao6 @rpotter12 @nileshpatra
Anyone working on this issue?

@xandao-dev
Copy link
Collaborator

I think nobody

@rpotter12
Copy link
Member

I will look at this in some days. I'm little busy these days.

@arpitasahakundu
Copy link

i want to work on this issue

@rpotter12
Copy link
Member

@arpitasahakundu That's for me. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants