Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using Category feature, invisible setting is not honored if a sequence in the same category is set to be visible #95

Closed
br2083 opened this issue Nov 18, 2023 · 3 comments · Fixed by #120
Assignees
Labels
bug Something isn't working
Milestone

Comments

@br2083
Copy link

br2083 commented Nov 18, 2023

Your Show Name:
lightsonventurepark

Describe the bug:
When using the Category feature, if even a single sequence is set to be visible, it overrides all other sequences of the same category to also be visible even though they're set to be invisible.

To Reproduce:
Steps to reproduce the behavior:
I added a group of sequences to a "Post Christmas" category and had them all marked as invisible. This worked fine on my viewer page. I toggled a single one of those sequences to be visible, refreshed the viewer page, and now all sequences in that category were shown on the viewer page.

Expected behavior:
To prioritize visible/invisible setting over the category.

@br2083 br2083 added the bug Something isn't working label Nov 18, 2023
@whitesoup12
Copy link
Owner

I can look into this. For the time being couldn't you just remove the category from the hidden sequences?

@br2083
Copy link
Author

br2083 commented Nov 19, 2023

For my purposes, I'm going to have the entire category hidden until I make them all visible at the same time so it shouldn't be an issue for me. It was just something I stumbled upon while testing so figured I'd report it in case it helped someone else.

@whitesoup12
Copy link
Owner

Fixed in PR #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants