Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit progress is deleted after CSRF/Network errors #19

Open
mac-chaffee opened this issue Jun 29, 2024 · 0 comments
Open

Edit progress is deleted after CSRF/Network errors #19

mac-chaffee opened this issue Jun 29, 2024 · 0 comments

Comments

@mac-chaffee
Copy link

Just started using JWB, really enjoying it!

I noticed that if I leave my JWB browser tab open for a while and then come back to it, I'll sometimes hit CSRF errors (from here). That's expected, but hitting either "OK" or "Cancel" discards the current edit. Seems that the problem is caused by "OK" skipping to the next page, and "Cancel" triggering "Stop", both of which cause the current edit to be discarded.

Since the "confirm" modal takes focus, I'm also unable to save my edits by copying the contents into a separate document.

This can be reproduced by starting to edit a page, disabling internet access on your computer, then clicking "Save".

Unfortunately I don't have a clear fix in mind, since a page reload seems required to get a new CSRF token. Maybe some kind of error state where all buttons are disabled, but the text content can be freely copied out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant