-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
submit button: change "Submit Query" to "Submit" #1864
Comments
Hey @NovemLinguae , Since I'm just getting started with open source, can I take this issue? |
Sure. After writing the patch, don't forget to test using the instructions at https://github.com/wikimedia-gadgets/twinkle/blob/master/CONTRIBUTING.md#testing-your-code |
Of course @NovemLinguae, I'll make the necessary changes, test it out, and then I'll reach out to you with the updates. |
Hello @NovemLinguae, I have implemented the required modifications. Please take a moment to review them. |
Thanks for the PR. FYI, things move pretty slow around here. I will get to your PR eventually but am currently busy IRL. |
Hey @NovemLinguae, No problem at all. Feel free to check out this pull request whenever you have some free time. |
Hello @NovemLinguae, |
Sorry, busy with day job this week. I tend to get a burst of energy and clear the PR queue ever couple months. Things move a bit slowly around here. |
Resolved by #1865 |
"Submit Query" reminds me of querying an SQL database.
For submitting an HTML form, "Submit" should do fine.
Looks like this is some default text in Morebits.
button.textContent = msg('submit', 'Submit Query');
If not overridden, it shows up in modules such as Tag, RFPP, etc.
The text was updated successfully, but these errors were encountered: