Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submit button: change "Submit Query" to "Submit" #1864

Closed
NovemLinguae opened this issue Sep 7, 2023 · 9 comments
Closed

submit button: change "Submit Query" to "Submit" #1864

NovemLinguae opened this issue Sep 7, 2023 · 9 comments
Assignees
Labels

Comments

@NovemLinguae
Copy link
Member

NovemLinguae commented Sep 7, 2023

"Submit Query" reminds me of querying an SQL database.

For submitting an HTML form, "Submit" should do fine.

Looks like this is some default text in Morebits.

button.textContent = msg('submit', 'Submit Query');

If not overridden, it shows up in modules such as Tag, RFPP, etc.

image
@ATREAY
Copy link
Contributor

ATREAY commented Sep 9, 2023

Hey @NovemLinguae ,

Since I'm just getting started with open source, can I take this issue?

@NovemLinguae
Copy link
Member Author

Sure. After writing the patch, don't forget to test using the instructions at https://github.com/wikimedia-gadgets/twinkle/blob/master/CONTRIBUTING.md#testing-your-code

@ATREAY
Copy link
Contributor

ATREAY commented Sep 9, 2023

Of course @NovemLinguae, I'll make the necessary changes, test it out, and then I'll reach out to you with the updates.

@ATREAY
Copy link
Contributor

ATREAY commented Sep 9, 2023

Hello @NovemLinguae,

I have implemented the required modifications. Please take a moment to review them.

@NovemLinguae
Copy link
Member Author

Thanks for the PR. FYI, things move pretty slow around here. I will get to your PR eventually but am currently busy IRL.

@ATREAY
Copy link
Contributor

ATREAY commented Sep 10, 2023

Hey @NovemLinguae,

No problem at all. Feel free to check out this pull request whenever you have some free time.

@ATREAY
Copy link
Contributor

ATREAY commented Sep 22, 2023

Hello @NovemLinguae,
I would like to kindly request your assistance in reviewing my pull request, which has been open for two weeks.

@NovemLinguae
Copy link
Member Author

Sorry, busy with day job this week. I tend to get a burst of energy and clear the PR queue ever couple months. Things move a bit slowly around here.

@siddharthvp
Copy link
Member

Resolved by #1865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants