Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename "twinklefluff.js" to "twinklerollback.js" #1975

Open
NovemLinguae opened this issue Jun 22, 2024 · 3 comments · May be fixed by #1977
Open

rename "twinklefluff.js" to "twinklerollback.js" #1975

NovemLinguae opened this issue Jun 22, 2024 · 3 comments · May be fixed by #1977

Comments

@NovemLinguae
Copy link
Member

NovemLinguae commented Jun 22, 2024 •
edited
Loading

Unlike the other module names, "fluff" is not descriptive of what the module does. The word is meaningless to new devs

Thanks to @nardog for the idea.
@Rustykitty
Copy link
Contributor

@NovemLinguae Do you want the file only to be renamed, or should the module also be renamed (from Twinkle.fluff to Twinkle.rollback)?

@NovemLinguae
Copy link
Member Author

I'm thinking the module too please.

@Rustykitty
Copy link
Contributor

I believe I have the module renamed most of the way, but I'd like to make sure that both fluff and rollback in Twinkle.disabledModules (on config) make the checkbox checked and I'm not quite sure how to do that. (I thought about adding a condition for checking that specific checkbox, but I don't think that's a good idea.

@NovemLinguae NovemLinguae linked a pull request Oct 16, 2024 that will close this issue
rename twinklefluff.js to twinklerollback.js #1977
Open
@NovemLinguae NovemLinguae linked a pull request Oct 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rename twinklefluff.js to twinklerollback.js NovemLinguae/twinkle
2 participants
@NovemLinguae @Rustykitty