Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compose About Activity conversion #5246

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Compose About Activity conversion #5246

wants to merge 34 commits into from

Conversation

Williamrai
Copy link
Collaborator

@Williamrai Williamrai commented Jan 21, 2025 •
edited
Loading

What does this do?

Converts About Activity to Compose

Phabricator:
https://phabricator.wikimedia.org/T384362

This also resolves the license screen issue.
https://phabricator.wikimedia.org/T384526

@Williamrai
- adds ComposeAboutActivity
b7f03be 
- adds HtmlText component
- adds preference for testing
@Williamrai Williamrai added the WIP Work in progress label Jan 21, 2025
@Williamrai
- removes XML AboutActivity.kt and its dependencies
7551a9e 
- adds proper html string
- adds body and footer for the about Activity
- updates Snackbar, HtmlText
- fixes app theme issue,
- ui fixes
@Williamrai Williamrai added HOLD Will review as soon as other more pressing PRs are merged/released. and removed WIP Work in progress labels Jan 23, 2025
@Williamrai Williamrai added WIP Work in progress and removed HOLD Will review as soon as other more pressing PRs are merged/released. labels Feb 7, 2025
@Williamrai Williamrai added Ready to merge PR passed design signoff and ready to be merged. and removed WIP Work in progress labels Feb 7, 2025
dbrant
dbrant requested changes Feb 14, 2025
View reviewed changes
Copy link
Member

@dbrant dbrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of tiny things:

  • Can the activity have a scrollbar when scrolling? Currently there's no visible scrollbar.
  • The snackbar appears to be slightly too "low" (notice the shadow cut off at the bottom). Can it have a default bottom margin of ~8dp?
    image

@Williamrai
Copy link
Collaborator Author

Williamrai commented Feb 14, 2025 •
edited
Loading

A couple of tiny things:

  • Can the activity have a scrollbar when scrolling? Currently there's no visible scrollbar.
  • The snackbar appears to be slightly too "low" (notice the shadow cut off at the bottom). Can it have a default bottom margin of ~8dp?
    image

Android Compose does not have default scrollbar, we would have to create a custom scrollbar, draw the component and also track it probably. Should we create a custom component for scrollbars?

@Williamrai Williamrai requested review from cooltey and dbrant February 18, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooltey cooltey cooltey approved these changes

@dbrant dbrant Awaiting requested review from dbrant dbrant is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Ready to merge PR passed design signoff and ready to be merged.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Williamrai @dbrant @cooltey