-
-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Espresso fixes #5344
base: main
Are you sure you want to change the base?
Espresso fixes #5344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor comments:
app/src/androidTest/java/org/wikipedia/tests/explorefeed/BecauseYouReadTest.kt
Outdated
Show resolved
Hide resolved
click.onViewWithText("Got it") | ||
delay(TestConfig.DELAY_MEDIUM) | ||
} catch (e: Exception) { | ||
Log.e("ReadingListRobot:", "Text does not exist.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary for a Espresso test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not necessary but i added log here to give some context.
What does this do?
Fixes espresso test failures