Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Espresso fixes #5344

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Espresso fixes #5344

wants to merge 8 commits into from

Conversation

Williamrai
Copy link
Collaborator

What does this do?

Fixes espresso test failures

@Williamrai Williamrai added the WIP Work in progress label Feb 21, 2025
@Williamrai Williamrai added Ready to merge PR passed design signoff and ready to be merged. and removed WIP Work in progress labels Feb 21, 2025
Copy link
Collaborator

@cooltey cooltey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments:

click.onViewWithText("Got it")
delay(TestConfig.DELAY_MEDIUM)
} catch (e: Exception) {
Log.e("ReadingListRobot:", "Text does not exist.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary for a Espresso test?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not necessary but i added log here to give some context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge PR passed design signoff and ready to be merged.
Development

Successfully merging this pull request may close these issues.

2 participants